fix: export TweakedPublicKey and fix JSDoc comments in bip341.d.ts#2247
Open
VolodymyrBg wants to merge 1 commit intobitcoinjs:masterfrom
Open
fix: export TweakedPublicKey and fix JSDoc comments in bip341.d.ts#2247VolodymyrBg wants to merge 1 commit intobitcoinjs:masterfrom
VolodymyrBg wants to merge 1 commit intobitcoinjs:masterfrom
Conversation
VolodymyrBg
commented
Jul 20, 2025
VolodymyrBg
commented
- Export TweakedPublicKey interface
- Fix tapleafHash return type documentation (Buffer -> Uint8Array)
- Clarify tweakKey hash parameter as optional
junderw
requested changes
Jul 20, 2025
Member
junderw
left a comment
junderw
left a comment
There was a problem hiding this comment.
Needs TS and JS changes.
In general, you should modify the TS, then run build and the d.ts file and js file will be automatically generated.
... also CI is broken... not sure why.
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.